Support global character initialization and initialization with logical and equality operators #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Dec 18, 2024
ChAoSUnItY
approved these changes
Dec 18, 2024
vacantron
approved these changes
Dec 18, 2024
DrXiao
reviewed
Dec 18, 2024
src/parser.c
Outdated
| res = op1 || op2; | ||
| break; | ||
| case OP_eq: | ||
| res = op1 == op2 ? 1 : 0; |
There was a problem hiding this comment.
If possible, directly rewrite it as res = op1 == op2 to avoid generating branch instructions.
src/parser.c
Outdated
| res = op1 == op2 ? 1 : 0; | ||
| break; | ||
| case OP_neq: | ||
| res = op1 != op2 ? 1 : 0; |
- Refactor read_numeric_sconstant function:
- Support character initialization.
- Support brackets with primary values only.
- Rename to read_primary_constant for clarity.
- Refactor eval_expression_imm:
- Add support for logical and equality operators:
- OP_log_and, OP_log_or, OP_eq, OP_neq.
- Add tests:
- Global character initialization.
- Global initialization with logical and equality operations.
|
Thank @AW-AlanWu for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where global assignments cannot assign characters and do not support logical and equality operators. Corresponding tests have been added to ensure these changes.