Skip to content

Commit

Permalink
scripts: Version EC separately from SBIOS
Browse files Browse the repository at this point in the history
The original rationale for having the EC version match the SBIOS version
was to ensure that compatible versions of each were installed. So we set
the EC version to the SBIOS version and always flash both of them, even
if only one actually changed.

At some point, a mechanism should be implemented that checks for a
minimum supported/compatible version. This would be comparable to the
LVFS MetaInfo's "requires" field.

Ref: f4f4d5b ("Build EC as a submodule, specifying version")
Signed-off-by: Tim Crawford <[email protected]>
  • Loading branch information
crawfxrd committed Feb 21, 2024
1 parent 85896ec commit 0ac1719
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ features apply to your model and firmware version, see the
- tgl: Updated FSP to A.0.7E.70
- tgl-u: Update microcode to revision 0xac
- tgl-h: Update microcode to revision 0x46
- Changed the EC version to be distinct from the SBIOS version

## 2024-01-18

Expand Down
2 changes: 1 addition & 1 deletion scripts/_build/ec.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ done < "$1"
BUILD_DIR="build"

make -C ec BUILD="$BUILD_DIR" clean
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
cp "ec/$BUILD_DIR/ec.rom" "$2"
3 changes: 1 addition & 2 deletions scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ KERNELVERSION="${VERSION}" \
# Rebuild EC firmware for System76 EC models
if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ]
then
env VERSION="${VERSION}" \
./scripts/_build/ec.sh \
./scripts/_build/ec.sh \
"${MODEL_DIR}/ec.config" \
"${BUILD}/ec.rom"
fi
Expand Down

0 comments on commit 0ac1719

Please sign in to comment.