Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thelio Major R5-N3 #270

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Thelio Major R5-N3 #270

merged 2 commits into from
Oct 23, 2024

Conversation

jacobgkau
Copy link
Member

@jacobgkau jacobgkau commented Oct 19, 2024 •
edited
Loading

This adds the Thelio Major R5-N3 (thelio-major-r5-n3) to tech docs.

@jacobgkau jacobgkau marked this pull request as draft October 19, 2024 01:27
@jacobgkau
Copy link
Member Author

jacobgkau commented Oct 22, 2024 •
edited
Loading

This is finished other than needing to confirm the GPU clearance with mechanical engineering.

Edit: Looks like the clearance had not changed from previous revisions and was correct.

@jacobgkau jacobgkau marked this pull request as ready for review October 23, 2024 14:18
@jacobgkau jacobgkau requested review from a team October 23, 2024 14:18
leviport
leviport requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few small problems, but this otherwise looks excellent!

src/models/thelio-major-r5-n3/README.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/README.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Outdated Show resolved Hide resolved
src/models/thelio-major-r5-n3/repairs.md Show resolved Hide resolved
leviport
leviport approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@jacobgkau jacobgkau merged commit bd7db13 into master Oct 23, 2024
1 check passed
@jacobgkau jacobgkau deleted the major branch October 23, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviport leviport leviport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobgkau @leviport