-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions for CI #17
base: master
Are you sure you want to change the base?
Conversation
- When a new PR is submitted, autoformat code with autopep8 and remove commented out code - After reformatting, commit back to the pull request - When reformatted code has been committed, lint it with pycodestyle On github side we will - Require all changes to be submitted as PRs - Require all CI checks to pass before merging PRs This change partially-fixes #1 and fixes #10
- This will be needed for CI later - This is required for the python setup stage of my github action (act didn't catch that locally)
- The one I was using previously did not support pull requests
- If we do, the linter will still have the old environment, so it will be ineffective
45a9d20
to
2a7329d
Compare
@Minion3665 I have made the repo public |
Looks good, not entirely sure about You could use the command |
I'll take a look at using poetry. I think even if eradicate does give an occasional false positive it isn't much of an issue as we'll still have the old commits in our history, so I'm not too worried about the chance of that happening |
Don't worry too much about using poetry but add the packages used to the dev dependencies so they could be run/pre-checked before pushing.
That would be annoying to do but fair |
commented out code
On github side we will
This change partially-fixes #1 and fixes #10