Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jellyfin to the Caddyfile automatically #27

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

AiroPi
Copy link
Contributor

@AiroPi AiroPi commented Feb 22, 2024

This follows the Pull Request nextcloud/all-in-one#4267.

This adds a Jellyfin rule in the Caddyfile to allow remote access to the Jellyfin instance with SSL.

I didn't test it, since this would include pushing a Docker image to Docker Hub and replacing the image ref in the Caddy community-container. Since the changes are very basic, I don't think there will be any issues.

Copy link
Owner

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR! I have 2 remarks...

start.sh Outdated Show resolved Hide resolved
start.sh Show resolved Hide resolved
AiroPi and others added 2 commits February 23, 2024 10:07
Change jellyfin to media as the subdomain

Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Pıεяяε <[email protected]>
Add GEOFILTER

Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Pıεяяε <[email protected]>
@AiroPi
Copy link
Contributor Author

AiroPi commented Feb 23, 2024

Overall, maybe I prefer jellyfin as a subdomain. It seems like a "standard" way to go, and it will avoid any conflict with other apps such as Plex. I'm still not totally sure. What is your opinion?

@szaimen
Copy link
Owner

szaimen commented Feb 23, 2024

Overall, maybe I prefer jellyfin as a subdomain. It seems like a "standard" way to go, and it will avoid any conflict with other apps such as Plex.

Plex uses its own system so it will not conflict.

I'm still not totally sure. What is your opinion?

I would go with media.... :)

Copy link
Owner

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@szaimen szaimen added the enhancement New feature or request label Feb 23, 2024
@szaimen szaimen merged commit 584e230 into szaimen:main Feb 23, 2024
2 checks passed
@szaimen
Copy link
Owner

szaimen commented Feb 23, 2024

This should be available once https://github.com/szaimen/aio-caddy/actions/runs/8020885232 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants