Skip to content

Commit

Permalink
fix php 8.4 deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
tacman committed Nov 21, 2024
1 parent c17c7f1 commit 3011084
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
# All supported PHP versions https://www.php.net/supported-versions.php
php: [ '7.3', '7.4', '8.0', '8.1' ]
php: [ '8.2','8.3','8.4' ]

runs-on: ${{matrix.os}}

Expand Down
2 changes: 1 addition & 1 deletion src/Oauth/PhpFlickrService.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function __construct(
ClientInterface $httpClient,
TokenStorageInterface $storage,
SignatureInterface $signature,
UriInterface $baseApiUri = null
?UriInterface $baseApiUri = null
) {
if ($baseApiUri === null) {
$baseApiUri = new Uri(static::$baseUrl . '/rest/');
Expand Down
4 changes: 2 additions & 2 deletions src/PhotosApi.php
Original file line number Diff line number Diff line change
Expand Up @@ -847,9 +847,9 @@ public function setContentType($photoId, $contentType)
*/
public function setDates(
$photoId,
DateTime $dateTaken = null,
DateTime|null $dateTaken = null,
$dateTakenGranularity = null,
DateTime $datePosted = null
DateTime|null $datePosted = null
) {
$args = ['photo_id' => $photoId];
if (!empty($dateTaken)) {
Expand Down
2 changes: 1 addition & 1 deletion src/PhpFlickr.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class PhpFlickr
* @param string $apiKey
* @param string|null $secret
*/
public function __construct(string $apiKey, string $secret = null)
public function __construct(string $apiKey, string|null $secret = null)
{
$this->api_key = $apiKey;
$this->secret = $secret;
Expand Down

0 comments on commit 3011084

Please sign in to comment.