Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Equality on addresses, slices, cells. #1279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: Equality on addresses, slices, cells. #1279

wants to merge 1 commit into from

Conversation

jeshecdom
Copy link
Contributor

Issue

Towards #539.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@jeshecdom jeshecdom requested a review from a team as a code owner January 3, 2025 10:24
anton-trunov
anton-trunov requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, just some minor comments

src/test/e2e-emulated/contracts/semantics.tact
// Addresses are immutable.

let addr1 = myAddress();
let addr2 = contractAddress(initOf SemanticsTester());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add this equality to the docs, if it's not there yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add something to initOf() for the time being. Later, this moment can be expanded upon in #925 and #1200

src/test/e2e-emulated/contracts/semantics.tact

/*************** Cells ********************/

get fun testCellEquality(): Bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests for cells obtained in a different way, not just from structs

@anton-trunov anton-trunov requested a review from novusnota January 3, 2025 11:47
@anton-trunov anton-trunov self-assigned this Jan 5, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

@novusnota novusnota Awaiting requested review from novusnota

Requested changes must be addressed to merge this pull request.

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeshecdom @anton-trunov @novusnota