-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ECDSA and repair Clang build #26
base: master
Are you sure you want to change the base?
Conversation
Reviewing. |
I successfully tested just the first two commits (
and also the same commit with just the embedded cryptopp on OS-X 10.10.5 . All three configs worked. How about we land just the first two commits and move the rest to a different PR? |
I'm good with landing the first two commits and moving the rest to a different PR, but I'd really prefer it if I could see a Mac OS 10.10.5 buildslave go from red to green when we land them (because https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2527). |
Buildslave is online (https://tahoe-lafs.org/buildbot-pycryptopp/waterfall) and red, as expected. Land away. |
@warner Can you reconnect your Mac OS X buildslave, please? |
#27 landed the first two patches. |
I'll try to spin it back up on wednesday night. It's running 10.11 now, though. |
BTW, buildslave is back online as of yesterday (https://tahoe-lafs.org/buildbot-pycryptopp/waterfall), OS-X (10.11) builder is currently green |
This is literally just
git cherry-pick dcb1dee5c47..32c05f3c
from zooko's85_disable_asm
branch at https://github.com/zooko/pycryptopp/tree/85_disable_asm — these two changes are kinda intertwined.