Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ECDSA and repair Clang build #26

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

twopir
Copy link

@twopir twopir commented Apr 13, 2015

This is literally just git cherry-pick dcb1dee5c47..32c05f3c from zooko's 85_disable_asm branch at https://github.com/zooko/pycryptopp/tree/85_disable_asm — these two changes are kinda intertwined.

@daira
Copy link
Member

daira commented Apr 14, 2015

Reviewing.

@daira
Copy link
Member

daira commented Apr 14, 2015

Finished reviewing. Overall -1 for now, see the comments on [85fbeba] and [2f11e66], and split out the ECDSA removal into a separate pull request.

@warner
Copy link
Member

warner commented Oct 13, 2015

I successfully tested just the first two commits (git checkout cd7a209) on a debian/sid box in two modes:

  • python setup.py build (embedded cryptopp)
  • apt-get install libcrypto++-dev, python setup.py build --disable-embedded-cryptopp

and also the same commit with just the embedded cryptopp on OS-X 10.10.5 . All three configs worked.

How about we land just the first two commits and move the rest to a different PR?

@zooko
Copy link
Member

zooko commented Oct 13, 2015

I'm good with landing the first two commits and moving the rest to a different PR, but I'd really prefer it if I could see a Mac OS 10.10.5 buildslave go from red to green when we land them (because https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2527).

@warner
Copy link
Member

warner commented Oct 14, 2015

Buildslave is online (https://tahoe-lafs.org/buildbot-pycryptopp/waterfall) and red, as expected. Land away.

@zooko
Copy link
Member

zooko commented Jan 3, 2016

@warner Can you reconnect your Mac OS X buildslave, please?

@zooko
Copy link
Member

zooko commented Jan 3, 2016

#27 landed the first two patches.

@warner
Copy link
Member

warner commented Jan 4, 2016

I'll try to spin it back up on wednesday night. It's running 10.11 now, though.

@warner
Copy link
Member

warner commented Jan 28, 2016

BTW, buildslave is back online as of yesterday (https://tahoe-lafs.org/buildbot-pycryptopp/waterfall), OS-X (10.11) builder is currently green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants