Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: move node search to background and fix avatar padding #574

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

barnstar
Copy link
Member

fixes tailscale/corp#24847
fixes tailsacle/corp#24848

Search jobs are moved to the default dispatcher so they do not block the UI thread.

The avatar boxing is now used only conditionally on AndroidTV.

@barnstar barnstar force-pushed the jonathan/one_seventy_eight_fixes branch from f4bbd44 to 6807275 Compare November 26, 2024 20:45
fixes tailscale/corp#24847
fixes tailsacle/corp#24848

Search jobs are moved to the default dispatcher so they
do not block the UI thread.

The avatar boxing is now used only conditionally on AndroidTV.

Signed-off-by: Jonathan Nobels <[email protected]>
@barnstar barnstar force-pushed the jonathan/one_seventy_eight_fixes branch from 6807275 to 0a1a26f Compare November 26, 2024 20:48
Copy link
Collaborator

@agottardo agottardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Pixel 7a and Android TV simulator, no UI regressions identified.

Search UI is still a bit laggy, although a tiny bit better.

@barnstar barnstar merged commit f35b3f9 into main Nov 26, 2024
4 checks passed
@barnstar barnstar deleted the jonathan/one_seventy_eight_fixes branch November 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants