Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final-capstone-Frontend : Doctor Appointment #13

Merged
merged 268 commits into from
Nov 22, 2023
Merged

Final-capstone-Frontend : Doctor Appointment #13

merged 268 commits into from
Nov 22, 2023

Conversation

tajulafreen
Copy link
Owner

@tajulafreen tajulafreen commented Nov 21, 2023

In this PR we did the following:

  • The user logs in to the website, only by typing the username (a proper authenticated login is a requirement if your group is made of 5 people).
  • In the navigation panel, the user can see links to:
    • Motorcycles/doctors/classes/items that you selected as a theme.
    • "Reserve" form.
    • "My reservations".
    • "Add motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).
    • "Delete motorcycle/doctor/class/item that you selected as a theme" (the link is visible to everybody).
  • On the main page, the user can see a list of motorcycles/doctors/classes/items that you selected as a theme.
  • When the user selects a specific item, they can see the details page with its full description (skip the "Rotate image" button).
    • In the details page, the user can click the "Reserve" button (in the design you can see the "Configure" button - please replace it with the "Reserve" button).
  • When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.
  • Make the app responsive, creating both mobile and desktop versions.
  • When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with title and "Delete" button.
    • When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.
  • To reserve an appointment, the user has to select a date and city (username and selected item are autofilled).
    • Use the design based on the "Book a vespa test-ride" and add all necessary inputs.
    • The user can also access the "Reserve" page from the navigation panel. In that case only username is autofilled
  • When the user clicks the "My reservations" link in the navigation panel they can see a list of their reservations (with information about item name, date and city).
  • Add full documentation for your API.

Backend

DianaBeki and others added 30 commits November 7, 2023 19:04
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tajulafreen,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Nice code organization ✔️
  • Good readme ✔️
  • Beautiful frontend ✔️

WARNING: The reservations feature didn't work for me on Firefox. It works fine on Chrome though.

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


README.md Show resolved Hide resolved
src/components/pages/newReservation.js Show resolved Hide resolved
src/components/pages/newReservation.js Show resolved Hide resolved
@tajulafreen tajulafreen requested a review from Meltrust November 22, 2023 11:27
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tajulafreen,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Tests are now passing✔️
  • Validation has been added to restrict reservations in the past✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


<a name="readme-top"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In this review iteration, one test is failing:

image

Kindly correct it. 👍

Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tajulafreen ,

Wow, you did it 🎉

Brilliant

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

applause

To highlight

  • NIce work✔️

Cheers and Happy coding!👏👏👏


@DianaBeki DianaBeki merged commit e560feb into main Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants