Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC authentication #25

Closed
sr-gi opened this issue Feb 24, 2022 · 3 comments · Fixed by #59
Closed

Add gRPC authentication #25

sr-gi opened this issue Feb 24, 2022 · 3 comments · Fixed by #59
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@sr-gi
Copy link
Member

sr-gi commented Feb 24, 2022

Currently, the gRPC API is non-authenticated, meaning that anyone could manage the tower if the API was offered outside localhost. This is obviously not safe, so gRPC TLS Auth needs to be added.

In the meantime, the RPC interface MUST NOT be advertised outside localhost.

@sr-gi
Copy link
Member Author

sr-gi commented Mar 10, 2022

@orbitalturtle started working on this in the old python codebase. If you, eager new contributor, are considering tackling this it may be a good idea to take a look at her approach: talaia-labs/python-teos#262

@sr-gi sr-gi added feature request New feature or request good first issue Good for newcomers labels Mar 10, 2022
@orbitalturtle
Copy link
Contributor

Giving this a go :)

@sr-gi
Copy link
Member Author

sr-gi commented Apr 14, 2022

Yaaay! Happy to have you around 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants