Mtls auth rpc #59
Merged
Mtls auth rpc #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalturtle
force-pushed
the
mtls-auth-rpc
branch
from
76d58b6 to
b9ae451
Compare
sr-gi
requested changes
Jun 10, 2022
There was a problem hiding this comment.
Looks great. Comments are mainly nits and idiomatic stuff.
Two comments on top of the inline ones:
- Is anyhow really necessary? I think the dependency kind off comes from CLN using it for their stuff, but given how few errors need to be handled and that we are not using it for the CLI it may be worth reworking this without it.
- The README.md will need to be updated to take the keys/certs into account. i.e. specify that after running the tower, if the CLI is run remotely, then the corresponding keys need to be placed on the remote machine in the corresponding folder and so on.
orbitalturtle
force-pushed
the
mtls-auth-rpc
branch
2 times, most recently
from
c12dfd4 to
6146fa8
Compare
|
@sr-gi Thanks for the review :D Made those changes |
sr-gi
requested changes
Jun 13, 2022
orbitalturtle
force-pushed
the
mtls-auth-rpc
branch
from
6146fa8 to
388aaff
Compare
|
@sr-gi Radtastic, fixed those things up. |
sr-gi
previously approved these changes
Jun 14, 2022
sr-gi
dismissed
their stale review
Didn't check the linter before approving, some additional changes are required
sr-gi
requested changes
Jun 14, 2022
orbitalturtle
force-pushed
the
mtls-auth-rpc
branch
2 times, most recently
from
bab8254 to
d04f3a7
Compare
|
@sr-gi ah fixed! |
sr-gi
approved these changes
Jun 15, 2022
|
ACK d04f3a7 |
|
@orbitalturtle in order to merge this, all commits need to be signed. Can you fix that and rebase? |
Signed-off-by: Orbital <[email protected]>
Signed-off-by: Orbital <[email protected]>
Signed-off-by: Orbital <[email protected]>
orbitalturtle
force-pushed
the
mtls-auth-rpc
branch
from
d04f3a7 to
2128de8
Compare
|
Sure thing :) The commits are now signed. @sr-gi |
|
ACK 2128de8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mtls to connect to the server's private api. Updates the cli to use mtls as well. Closes #25