Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitpod.md #1244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Gitpod.md #1244

wants to merge 1 commit into from

Conversation

KDMcMullan
Copy link
Contributor

Changed ' "/tasmota" root directory' to avoid time spent looking in "/tasmota".

Changed ' "/tasmota" root directory' to avoid time spent looking in "/tasmota".
@blakadder
Copy link
Contributor

that makes no sense

@KDMcMullan
Copy link
Contributor Author

Quite correct. On reflection, it would make more sense to change it to "/TASMOTA root directory".

The guide is an excellent piece for someone who's not used GitPod before nor compiled TASMOTA before. As such a person, I followed the guide. Unfortunately the /TASMOTA directory contains a folder called tasmota, so I spent some minutes looking for platformio.ini in /TASMOTA/tasmota, when I should have been looking in /TASMOTA. In my fluster, I missed the instruction to scroll to the bottom.

There's an inconsistency, though. Elsewhere in the document, we are instructed to create user_config_override.h in the /tasmota folder. In this case, I'd suggest it changes to /TASMOTA/tasmota .

If you wish to reject the change, I'll gladly make a more appropriate suggestion. Do you prefer:

Select the /tasmota folder in the Explorer (1) pane. Create a new file called user_config_override.h
(which could be perceived wrongly as it's actually /TASMOTA)

or

Open the platformio.ini file located in the /tasmota root directory
(which could be perceived wrongly as it's actually /TASMOTA/tasmota)

Thanks for looking.

@barbudor
Copy link
Collaborator

May be just
located at the bottom of the file Explorer pane.

And add a picture of that:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants