Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #167

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 6, 2023

@clemens-fricke
Copy link
Collaborator

I saw that blackdoc dropped support for python 3.7, and after that I checked if the main branch is still able to be run with this version and it is not. (Only for pre-commit)

This means that gustaf can only be developed with python>=3.8, which I think should not be a problem. Since this should not change the ability of users to run the package with the older python version.

Only development should have this issue not usage!

The only thing we should check is that CI pre-commit is only run in a version that is supported.

clemens-fricke
clemens-fricke previously approved these changes Nov 9, 2023
Copy link
Collaborator

@clemens-fricke clemens-fricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment. Other than that no problems.

updates:
- [github.com/psf/black: 23.10.1 → 23.11.0](psf/black@23.10.1...23.11.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.3 → v0.1.5](astral-sh/ruff-pre-commit@v0.1.3...v0.1.5)
- [github.com/keewis/blackdoc: v0.3.8 → v0.3.9](keewis/blackdoc@v0.3.8...v0.3.9)
Copy link
Collaborator

@clemens-fricke clemens-fricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above statement still holds. Can not be run on py3.7 anymore (which should already be the case for the current main branch).

But functionally it does not produce changes in the current code base (none showed up in my testing at least).

@j042
Copy link
Member

j042 commented Nov 15, 2023

what's the status on pyproject.toml updates? @clemens-fricke

@j042 j042 merged commit 87d42c9 into main Nov 15, 2023
14 checks passed
@j042 j042 deleted the pre-commit-ci-update-config branch November 15, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants