Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unwritable issues, and tangled ref #195

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix unwritable issues, and tangled ref #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions gustaf/vertices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def bounds(self):
bounds: (d,) np.ndarray
"""
self._logd("computing bounds")
return utils.arr.bounds(self.const_vertices)
return utils.arr.bounds(self.vertices)

@helpers.data.ComputedMeshData.depends_on(["vertices"])
def bounds_diagonal(self):
Expand Down Expand Up @@ -487,7 +487,14 @@ def copy(self):
self_copy: type(self)
"""
# all attributes are deepcopy-able
return copy.deepcopy(self)
copied = copy.deepcopy(self)

# update helpee. otherwise keeps reference to self
copied._show_options._helpee = copied
copied._vertex_data._helpee = copied
copied._computed._helpee = copied

return copied

@classmethod
def concat(cls, *instances):
Expand Down
Loading