Add Vite support #33
Merged
Add Vite support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is super exciting, thanks for starting it! I hope to test it out in the next couple weeks, and if it looks like everything still works we'll switch over. The PWA config is what I'd be most worried about. |
|
I had a chance to try this out and it looks like it works. I'm going to merge for now and would be happy to change the official build to use vite, test that a bit on the live site, then delete the parcel setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Vite support alongside Parcel support. Parcel continues to work as it always has. You can use
yarn build:vite && yarn start:viteas a drop-in replacement foryarn build && yarn start. You can also develop in Vite's very fast dev mode withyarn vite --open.