-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
models: update for AppStream 1.0 #617
Conversation
0d35f60
to
df50b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better, thanks. I will merge this as soon as GNOME runtime upgrades too.
@tchx84 is this still waiting for a runtime upgrade? Just had to include this in AUR/flatseal because of the crash on |
Yes, this change is still waiting for the runtime upgrade. Be assured that this will be merged once it happens. Please let me know if notice anything else. |
Unfortunately, GNOME 46 still ships with older appstream version.
|
Forgive if I am misunderstanding something here. Wouldn't it be a better idea to pull this, making the places that do not support the current stable API run into issues, making them figure out there is a new stable API and having to apply workarounds? Currently it's exactly the other way around, which seems to be punishing those who ship the current stable release. |
This now conflicts after the 2.2.0 release. EDIT: It's just a minor 1.4 -> 1.5 string change |
AppStream 1.0.0 includes several API breaks compared to the previous 0.16 (and earlier) versions, but unfortunately both versions used the same 1.0 GI version, so there is no way to differentiate at import time. Therefore, enforce the requirement during the build to make this clear.
GNOME 47 runtime has just been released: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/tags/47.0 (so this MR can finally move forward)
|
@yselkowitz thanks for the patience , merged with #710 |
AppStream 1.0.0 includes several API breaks compared to the previous 0.16 (and earlier) versions, but unfortunately both versions used the same 1.0 GI version, so there is no way to differentiate at import time.
As such, try/catch is used to fall back to the 0.16 API where they differ.Therefore, enforce the requirement during the build to make this clear.