Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: update for AppStream 1.0 #617

Closed
wants to merge 1 commit into from

Conversation

yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Nov 26, 2023

AppStream 1.0.0 includes several API breaks compared to the previous 0.16 (and earlier) versions, but unfortunately both versions used the same 1.0 GI version, so there is no way to differentiate at import time. As such, try/catch is used to fall back to the 0.16 API where they differ. Therefore, enforce the requirement during the build to make this clear.

src/models/applications.js Outdated Show resolved Hide resolved
@yselkowitz yselkowitz changed the title Fix errors with AppStream 1.0 models: update for AppStream 1.0 Dec 25, 2023
@yselkowitz yselkowitz requested a review from tchx84 December 25, 2023 23:23
Copy link
Owner

@tchx84 tchx84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thanks. I will merge this as soon as GNOME runtime upgrades too.

@C0rn3j
Copy link

C0rn3j commented Feb 7, 2024

@tchx84 is this still waiting for a runtime upgrade?

Just had to include this in AUR/flatseal because of the crash on component.get_developer().

@tchx84
Copy link
Owner

tchx84 commented Feb 7, 2024

@tchx84 is this still waiting for a runtime upgrade?

Just had to include this in AUR/flatseal because of the crash on component.get_developer().

Yes, this change is still waiting for the runtime upgrade. Be assured that this will be merged once it happens. Please let me know if notice anything else.

@tchx84
Copy link
Owner

tchx84 commented Mar 20, 2024

Unfortunately, GNOME 46 still ships with older appstream version.

$ flatpak run --command=appstreamcli org.gnome.Sdk//46 --version
AppStream version: 0.16.4

@C0rn3j
Copy link

C0rn3j commented Mar 20, 2024

Forgive if I am misunderstanding something here.

Wouldn't it be a better idea to pull this, making the places that do not support the current stable API run into issues, making them figure out there is a new stable API and having to apply workarounds?

Currently it's exactly the other way around, which seems to be punishing those who ship the current stable release.

@C0rn3j
Copy link

C0rn3j commented Apr 18, 2024

This now conflicts after the 2.2.0 release.

EDIT: It's just a minor 1.4 -> 1.5 string change

AppStream 1.0.0 includes several API breaks compared to the previous
0.16 (and earlier) versions, but unfortunately both versions used the
same 1.0 GI version, so there is no way to differentiate at import time.
Therefore, enforce the requirement during the build to make this clear.
@TheComputerGuy96
Copy link

TheComputerGuy96 commented Sep 18, 2024

GNOME 47 runtime has just been released: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/tags/47.0 (so this MR can finally move forward)

Edit: Well except for the CI which requires andyholmes/flatter#111 That MR got merged

@tchx84
Copy link
Owner

tchx84 commented Sep 18, 2024

@yselkowitz thanks for the patience , merged with #710

@tchx84 tchx84 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants