Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddAssertResult not checking limits of AssertResults array #190

Closed
doerk77 opened this issue Jun 15, 2022 · 2 comments
Closed

AddAssertResult not checking limits of AssertResults array #190

doerk77 opened this issue Jun 15, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
Release 1.3.0.0

Comments

@doerk77
Copy link

doerk77 commented Jun 15, 2022 •
edited
Loading

Describe the bug
When increasing TotalAsserts in method AddAssertResult the array limits of AssertResults are not being checked, causing PLC crash due to invalid array index.

Expected behavior
Prevent crash by limit checks and sending error through ADSLOGSTR.
Remark: Prevent overflow of event logger (error should only be raised once)!!!

Screenshots
image

Software versions
v1.2.0.0

has been mentioned earlier in #153
doerk77 pushed a commit to doerk77/TcUnit that referenced this issue Jun 17, 2022
@dlorenz-zep
Fix bug array limits exceeded for AssertResults and AssertArrayResult…
eb2a454 
…s and static assert handlers (see issue tcunit#190),

TcUnit updated + TcUnit-Verifier_TwinCAT updated to detect problem, TcUnit-Verifier_DotNet NOT updated
@sagatowski sagatowski added the enhancement New feature or request label Jun 20, 2022
@sagatowski
Copy link
Member

Pull request welcome.

doerk77 pushed a commit to doerk77/TcUnit that referenced this issue Jul 5, 2022
@dlorenz-zep
Update TcUnit_Verifier_DotNet to detect AssertCount problem (issue tc…
9212542 
…unit#190), Additional command line flag to use Visual Studio or XAE Shell - default set to XAE Shell -> Might require update to Jenkins call
@doerk77 doerk77 mentioned this issue Jul 5, 2022
Closed
@sagatowski sagatowski added this to the Release 1.3.0.0 milestone Nov 26, 2023
sagatowski added a commit that referenced this issue Nov 27, 2023
@sagatowski
Added functionality to check limits of AssertResults.
4a48bdd 
Linted markdown/documentation files.
See:
#190 - "AddAssertResult not checking limits of AssertResults array"
#193 - "Fix overflow of assert array limits"
@sagatowski
Copy link
Member

Solved in #193 & in commit 4a48bdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.3.0.0
Development

No branches or pull requests
2 participants
@sagatowski @doerk77