Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow of assert array limits #193

Closed
wants to merge 2 commits into from
Closed

Fix overflow of assert array limits #193

wants to merge 2 commits into from

Conversation

doerk77
Copy link

@doerk77 doerk77 commented Jul 5, 2022

Checking assertion array limits in TcUnit (issue #190).

  • Added tests to TcUnit-Verifier
  • Added code to detect failing tests in TcUnit-Verfier_DotNet.
  • Added additional command line option to use Visual Studio or XAE shell in TcUnit-Verfier_DotNet.
    Default DTE set to XAE shell -> Might require update to Jenkins call
  • Updated formatting to log output of TcUnit-Verfier_DotNet

@dlorenz-zep
Fix bug array limits exceeded for AssertResults and AssertArrayResult…
eb2a454 
…s and static assert handlers (see issue tcunit#190),

TcUnit updated + TcUnit-Verifier_TwinCAT updated to detect problem, TcUnit-Verifier_DotNet NOT updated
@dlorenz-zep
Update TcUnit_Verifier_DotNet to detect AssertCount problem (issue tc…
9212542 
…unit#190), Additional command line flag to use Visual Studio or XAE Shell - default set to XAE Shell -> Might require update to Jenkins call
@sagatowski
Copy link
Member

Thanks for this PR.
Please read the contributing, especially the part about "Use a Consistent Coding Style". As VS2013 is the default editor for this, the option run in in the XAE shell (which is so far based on VS2017) should be an option (default should be as it is right now).

Does this also solve #189?

sagatowski added a commit that referenced this pull request Nov 27, 2023
@sagatowski
Added functionality to check limits of AssertResults.
4a48bdd 
Linted markdown/documentation files.
See:
#190 - "AddAssertResult not checking limits of AssertResults array"
#193 - "Fix overflow of assert array limits"
@sagatowski
Copy link
Member

@doerk77 I manually copied the stuff over and commited everything in 4a48bdd.

Thanks for this, I'll add you to the contributors for the release. Appreciate your work!

@sagatowski sagatowski closed this Nov 30, 2023
This was referenced Nov 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doerk77 @sagatowski @dlorenz-zep