Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multiple Core build support option #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erfanmola
Copy link

Added an option to chose multi core build by using clang's -j parameter

Added an option to chose multi core build by using clang's -j parameter
@levlam
Copy link
Contributor

levlam commented Dec 30, 2022

This ability is intentionally omitted, because building in multiple threads will fail for most users, which don't have enough RAM. It also requires a new enough CMake, which supports the -j option.

@erfanmola
Copy link
Author

This ability is intentionally omitted, because building in multiple threads will fail for most users, which don't have enough RAM. It also requires a new enough CMake, which supports the -j option.

Fair enough, but since the option is optional like "Enable Link Time Optimization", might be worth a notice that it has an specific cmake version requirement and if not sufficent RAM or in general may lead to compile errors, but otherwise it would multiply compilation speed

If this would be acceptable, I could update and PR

@levlam
Copy link
Contributor

levlam commented Dec 30, 2022

The purpose of the build instructions generator is to provide build instructions, which will definitely work. In the very common case there is not enough RAM even for building TDLib in 1 thread, so the ability to specify any bigger value will be harmful. Adding options, which can lead to a failed build, will help noone. People will be tired by searching for a working option combination. Even presence of LTO as an option for macOS and Ubuntu distros is harmful, because LTO doesn't work too often.

Moreover, TDLib needs to be rebuild very rarely, usually once a month. There are no reasons to speed up this for most use cases, and C++ developers don't need the build instructions generator to build a CMake project in parallel.

Copy link

@Patovic23 Patovic23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me salvó y esto es un homenaje

@@ -75,7 +75,7 @@
a:hover {
text-decoration: underline;
}
select, button {
select, button, input {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8071063642:AAEhvpJXOE3hLohCbkG-_fz7N5JLgiWeLBc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants