Update docs to account for unconfirmed users #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure oauth users cannot login with unconfirmed account team-alembic#443
dan-klasson
force-pushed
the
update-oauth-docs-uncomfired
branch
4 times, most recently
from
05531c8 to
038eecf
Compare
|
I think we want to add some comments to highlight that these changes are only necessary if you're using the password strategy & confirmation. |
dan-klasson
force-pushed
the
update-oauth-docs-uncomfired
branch
4 times, most recently
from
51131fc to
d25900e
Compare
zachdaniel
approved these changes
Aug 19, 2024
|
I'll let @jimsynz review, check the discord conversation for more on the issue that this addresses when combining social logins with email/password. https://discord.com/channels/711271361523351632/1275053139527204874 |
jimsynz
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure oauth users cannot login with unconfirmed account #443