Skip to content
This repository has been archived by the owner on Dec 29, 2018. It is now read-only.

Support .js React extension out of the box #146

Merged
merged 3 commits into from
May 9, 2017

Conversation

mbchoa
Copy link
Member

@mbchoa mbchoa commented Apr 23, 2017

Changes

Updates

  • Renamed extension of App component in counter-example example app to .jsx to support testing of CLI deprecation change

Fixes

  • Fixed webpack error thrown when building bundle file by removing webpack.optimize.DedupePlugin() from counter-example webpack config

@mbchoa mbchoa requested review from jerrymao15 and jdavis218 April 23, 2017 19:41
Copy link
Member

@jdavis218 jdavis218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

Copy link
Member

@jerrymao15 jerrymao15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mike,
The changes look good, will merge!

@jerrymao15 jerrymao15 merged commit b90f26e into team-gryff:master May 9, 2017
@mbchoa mbchoa deleted the deprecate-ext-cli-param branch May 9, 2017 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants