Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DEV-13257): add min height to table components #462

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

saladNights
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 93f0ade

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@monite/sdk-react Minor
@team-monite/sdk-demo Patch
@monite/sdk-drop-in Patch
@monite/sdk-api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@PeCrio PeCrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we are using absolute numbers rather than pixel values?

@saladNights
Copy link
Collaborator Author

Is there a reason why we are using absolute numbers rather than pixel values?

it’s just a shorthand for 500px. But let's make it more explicit

@saladNights saladNights merged commit e8fe5a2 into dev Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants