feat(DEV-13399): add integrations page and finance application card #473
Conversation
PeCrio
changed the base branch from
dev
to
feat/DEV-13233-fe-kanmon-v-1-implementation
…ps://github.com/team-monite/monite-sdk into feat/DEV-13399-implement-integrations-page
🦋 Changeset detectedLatest commit: fdf6b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…/github.com/team-monite/monite-sdk into feat/DEV-13399-implement-integrations-page
.changeset/hungry-snakes-provide.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@monite/sdk-react': patch | |||
There was a problem hiding this comment.
two changest files. The change itself looks like minor, so this changeset should be removed probably
There was a problem hiding this comment.
Do you think we should have only 1 changeset for the full implementation rather than individual changesets?
There was a problem hiding this comment.
for these particular changesets, I see the same change description
feat(DEV-13399): add integrations page and finance application card
That is why I think you should keep only one. 1 PR = 1 changeset.
For your current approach, having individual changesets for sub-features is fine and then having one for full implementation.
There was a problem hiding this comment.
Okay, I'll update the changeset on this pull request to a minor.
PeCrio
merged commit cf1a0a6
into
feat/DEV-13233-fe-kanmon-v-1-implementation
No description provided.