fix(proposal): edit AR invoice update button unresponsive #492
Conversation
|
saladNights
changed the title
|
Fix the linter warnings please |
|
update branch with the latest changes form the base one |
| ? { vat_rate_id: lineItem.product.vat_rate.id, | ||
| vat_rate_value: lineItem.product.vat_rate.value, | ||
| } | ||
| : { tax_rate_value: lineItem.product.vat_rate.value / 100 }), |
There was a problem hiding this comment.
what does the '/ 100' means? If it's the conversion from to minor units, it is a wrong way to do so.
The conversion from/to minor units depends on the currency since there is a differect decimal for some currencies.
You should use formatFromMinorUnits/formatToMinorUnits functions form our util hooks.
There was a problem hiding this comment.
got it, I didn't know that
|
add a changeset and describe the implemented changes. It is required for detailed release notes |
Issue was presented by a customer where the update button in the invoice editing screen was not responsive when the entity is not VAT obligated
Issue:
tax rate value was not included, hence when VAT value was passed it didn't inculde any values
note for QA and testing - there's a quirk, when launching the SDK for the first time, the VAT rate IDs will not apply, however, when closing and opening the editing component will reflect the VAT rates and the issue doesn't appear for any other invoice