DOTCOM-3581: update deps and add typescript default config #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasassisrosa
changed the title
dmmc12
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Hey Lucas!
Some feedback from my local tests. The only issue I ran into was the linting where you can see the errors below.
Node.js Version: v20.13.1
npm Version: 10.5.2
git checkout remotes/origin/v2.0.0-DOTCOM-3581
Note: switching to 'remotes/origin/v2.0.0-DOTCOM-3581'
dillin@dillin-Latitude-7420:~/Desktop/Telnyx SDKs/telnyx-node$ npm install
npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm WARN deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
added 361 packages, and audited 362 packages in 2s
63 packages are looking for funding
run `npm fund` for details
3 moderate severity vulnerabilities
Some issues need review, and may require choosing
a different dependency.
Run `npm audit` for details.
$ npm run build
> [email protected] build
> tsc
✔️
$ ls dist
multipart.js utils.js
✔️
$ npm run lint
> [email protected] lint
> eslint --ext .js,.ts .
Invalid option '--ext' - perhaps you meant '-c'?
You're using eslint.config.js, some command line flags are no longer available. Please see https://eslint.org/docs/latest/use/command-line-interface for details.
I tried updating package.json with:
"lint": "eslint -c .js,.ts .",
or
"lint": "eslint .",
But then I run into this error:
dillin@dillin-Latitude-7420:~/Desktop/Telnyx SDKs/telnyx-node$ npm run lint
> [email protected] lint
> eslint -c .js,.ts .
Oops! Something went wrong! :(
ESLint: 8.57.0
Error: ENOENT: no such file or directory, stat '/home/dillin/Desktop/Telnyx SDKs/telnyx-node/.js,.ts'
at async Object.stat (node:internal/fs/promises:1029:18)
at async loadFlatConfigFile (/home/dillin/Desktop/Telnyx SDKs/telnyx-node/node_modules/eslint/lib/eslint/flat-eslint.js:272:20)
at async calculateConfigArray (/home/dillin/Desktop/Telnyx SDKs/telnyx-node/node_modules/eslint/lib/eslint/flat-eslint.js:382:28)
at async FlatESLint.lintFiles (/home/dillin/Desktop/Telnyx SDKs/telnyx-node/node_modules/eslint/lib/eslint/flat-eslint.js:745:25)
at async Object.execute (/home/dillin/Desktop/Telnyx SDKs/telnyx-node/node_modules/eslint/lib/cli.js:421:23)
at async main (/home/dillin/Desktop/Telnyx SDKs/telnyx-node/node_modules/eslint/bin/eslint.js:152:22)
10 tasks
thanks @dmmc12, I pushed a change to fix this linter issue. The config was stale on https://eslint.org/docs/latest/use/configure/migration-guide#--ext |
|
moving forward with this to branch v2.0.0 in favor of #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial typescript setup
@typesand (dev) dependenciesManual testing
npm run build