fix: check server side session for REST API endpoints #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check server side sessions in session middleware for REST API endpoints. Without it a server side session could be deleted, but can still be used at the REST API endpoints.
bjoern-m
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check server side sessions in session middleware for REST API endpoints. Without it a server side session could be deleted, but can still be used at the REST API endpoints.
Implementation
When server side sessions are enabled, check if the session is still stored in the database.
Tests
Delete a server side session and check that the REST API endpoints return
Unauthorizedwhen the deleted session token is used.