Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: support PHP 8.3 #25

Merged
merged 3 commits into from
Nov 19, 2024
Merged

task: support PHP 8.3 #25

merged 3 commits into from
Nov 19, 2024

Conversation

cngJo
Copy link
Contributor

@cngJo cngJo commented Nov 19, 2024

I installed it locally with --ignore-platform-reqs in a PHP 8.3 project and didn't notice any issues.

Let's see what the tests say 😉

Thanks for the Bundle!

Copy link
Contributor

@mike4git mike4git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it - thx for your PR

@jdreesen
Copy link
Member

I think we first need to allow PHP 8.3 in teamneusta/pimcore-testing-framework for the tests to pass.

@cngJo
Copy link
Contributor Author

cngJo commented Nov 19, 2024

Great, thank you! I've seen in the pipelines I ran in my repository, that your testing-framework seems to be not compatible with PHP 8.3 yet.

Are you working on that already? Otherwise, I'd offer to create a similar PR to this over there to raise it to PHP 8.3 ;)

@jdreesen
Copy link
Member

No, we're not currently working on it. If you want to create a PR, please target the v0.12 branch, as main currently contains some changes that are not yet ready to be released.

@lukadschaak
Copy link
Collaborator

I started a merge request on the testing framework.

As soon as this is merged and released i will update this one here as well.

@jdreesen
Copy link
Member

teamneusta/pimcore-testing-framework v0.12.8 with support for PHP 8.3 has just been relesed.

@lukadschaak lukadschaak merged commit 740cc20 into teamneusta:main Nov 19, 2024
7 checks passed
@lukadschaak
Copy link
Collaborator

Done https://github.com/teamneusta/pimcore-fixture-bundle/releases/tag/2.2.0

@cngJo
Copy link
Contributor Author

cngJo commented Nov 20, 2024

Awesome, thank you guys! 🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants