Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0 gem release #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

v3.0 gem release #4

wants to merge 6 commits into from
+30 −16

Conversation

mdeering
Copy link
Member

@mdeering mdeering commented May 12, 2018 •
edited
Loading

Fixes #3

Additional Notes

  • Added email_verified to the info passed through to prevent account takeover in 3rd parties using this for login or signup purposes.
    • Update readme with notes and recommendations for its usage.
  • Confirm any other projects that are using this are able to update or locked to the older version of this gem.
  • fix require 'omniauth-surveymonkey/omniauth-surveymonkey' => require 'omniauth-surveymonkey
  • Strategy should do the require 'omniauth' for us Update for version API 3.0 apps #3 (comment)

@mdeering
Copy link
Member Author

Looks like I missed a spot with the api_key not being optional I will have to test this with more than just the simples of scopes that SM login is using. https://github.com/techvalidate/omniauth-surveymonkey/pull/4/files#diff-eb15e497be553f6ea63d0efbb1ea30b9R38

@mdeering mdeering changed the title [WIP] V3 v3.0 gem release Jul 31, 2018
@mdeering mdeering self-assigned this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdeering mdeering

Labels
Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for version API 3.0 apps
1 participant
@mdeering