Adopt GHC902, Upgrade to Stack LTS 19.11 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vst
commented
Jun 16, 2022
vst
commented
- chore: adopt Stack lts-19.11 (and GHC902), add Nix Shell
- chore: drop deriving-aeson dependency
deriving-aeson is hit by a regression in compile times when working with Aeson 2.x: fumieval/deriving-aeson#16 PS: On an unrelated note, doctests are failing with: ``` stack test ``` ... but, at least, working with: ``` stack --stack-yaml stack-18.28.yaml test ```
fkoksal
reviewed
Jun 16, 2022
@fkoksal Indeed, no. I want to make sure that the library still works with lts-18.28 (and therefore ghc8107). But, at the moment, lts-18.28 is also the only/easiest way for us to run doctests until sol/doctest#327 is resolved while desperately assuming that test results are applicable to lts-19.11/ghc902, too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.