Skip to content

Commit

Permalink
Warn PR authors about the merge policy (#500)
Browse files Browse the repository at this point in the history
**What changed?**

Add a warning to the GitHub PR template reminding everyone that both
Server AND SDK teams must sign off on a PR before it's merged.

**Why?**

'Cause people have merged things a couple times now without SDK review.

**Breaking changes**

None
  • Loading branch information
josh-berry authored Nov 27, 2024
1 parent 3f42081 commit bae790a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._

<!-- Describe what has changed in this PR -->
**What changed?**

Expand Down

0 comments on commit bae790a

Please sign in to comment.