Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to exclude cancel request events from being reapplied beyond reset point #493

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Provide option to exclude cancel request events from being reapplied beyond reset point #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f37c6b0
reapply cancel
hai719 Nov 22, 2024
b4bb25c
Update temporal/api/enums/v1/reset.proto
hai719 Nov 25, 2024
ff7ec48
Merge branch 'master' into hai719/reapply
hai719 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10071,10 +10071,11 @@
"RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
"RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL",
"RESET_REAPPLY_EXCLUDE_TYPE_UPDATE",
"RESET_REAPPLY_EXCLUDE_TYPE_NEXUS"
"RESET_REAPPLY_EXCLUDE_TYPE_NEXUS",
"RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST"
],
"default": "RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point."
"description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST: Exclude cancel request events when reapplying events beyond the reset point."
},
"v1ResetReapplyType": {
"type": "string",
Expand Down
2 changes: 2 additions & 0 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7467,6 +7467,7 @@ components:
- RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
- RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
- RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
- RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
type: string
format: enum
description: Event types not to be reapplied
Expand Down Expand Up @@ -7553,6 +7554,7 @@ components:
- RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
- RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
- RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
- RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
type: string
format: enum
description: Event types not to be reapplied
Expand Down
2 changes: 2 additions & 0 deletions temporal/api/enums/v1/reset.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ enum ResetReapplyExcludeType {
RESET_REAPPLY_EXCLUDE_TYPE_UPDATE = 2;
// Exclude nexus events when reapplying events beyond the reset point.
RESET_REAPPLY_EXCLUDE_TYPE_NEXUS = 3;
// Exclude cancel request events when reapplying events beyond the reset point.
RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST = 4;
}

// Event types to include when reapplying events. Deprecated: applications
Expand Down
Loading