functional tests testing queries + nexus tasks with versioning-3 #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
Dec 19, 2024
| @@ -361,5 +361,6 @@ func MutableStateToGetResponse( | |||
| InheritedBuildId: mutableState.GetInheritedBuildId(), | |||
| MostRecentWorkerVersionStamp: mostRecentWorkerVersionStamp, | |||
| TransitionHistory: mutableState.GetExecutionInfo().TransitionHistory, | |||
| VersioningInfo: mutableState.GetExecutionInfo().VersioningInfo, | |||
There was a problem hiding this comment.
I think we might have forgotten to add this while making the versioning-3 changes - this is required for query tasks
Shivs11
commented
Dec 19, 2024
| @@ -239,9 +247,6 @@ func (p *workflowTaskPoller) pollTask( | |||
| } | |||
|
|
|||
| events = history.Events | |||
| if len(events) == 0 { | |||
There was a problem hiding this comment.
This required to be removed - I found out that sticky queries do not get sent "partial" histories and are sent empty histories
Shivs11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
taskPollerto now consider query and nexus tasksWhy?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?
No