Handle system time move backward case in timer task processing #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
force-pushed
the
fix-queues-is-time-expired
branch
from
fb5f5fd to
c3f87c1
Compare
bergundy
reviewed
Dec 23, 2024
| @@ -303,10 +304,14 @@ func (p *scheduledQueue) lookAheadTask() { | |||
| // IsTimeExpired checks if the testing time is equal or before | |||
| // the reference time. The precision of the comparison is millisecond. | |||
| func IsTimeExpired( | |||
There was a problem hiding this comment.
I would add a note explaining why we take the task here (to prevent clock skew issues).
| // NOTE: Persistence layer may lose precision when persisting the task, which essentially moves | ||
| // task fire time backward. But we are already performing truncation here, so doesn't need to | ||
| // account for that. | ||
| referenceTime = util.MaxTime(referenceTime, task.GetKey().FireTime).Truncate(persistence.ScheduledTaskMinPrecision) |
There was a problem hiding this comment.
What's the difference between visibility timestamp and fire time and why take that here?
| @@ -236,7 +240,7 @@ func (t *timerQueueStandbyTaskExecutor) executeActivityTimeoutTask( | |||
| // created. | |||
| isHeartBeatTask := timerTask.TimeoutType == enumspb.TIMEOUT_TYPE_HEARTBEAT | |||
| ai, heartbeatTimeoutVis, ok := mutableState.GetActivityInfoWithTimerHeartbeat(timerTask.EventID) | |||
| if isHeartBeatTask && ok && queues.IsTimeExpired(timerTask.GetVisibilityTime(), heartbeatTimeoutVis) { | |||
| if isHeartBeatTask && ok && queues.IsTimeExpired(timerTask, timerTask.GetVisibilityTime(), heartbeatTimeoutVis) { | |||
There was a problem hiding this comment.
Shouldn't we use referenceTime to allow progressing beyond the visibility timestamp in case task processing is delayed for a while?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?