Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Nav fixes for external control #2469

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

GiantRobots
Copy link
Contributor

…allow the escape button to close the nav.

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:53pm

src/lib/components/bottom-nav.svelte Outdated Show resolved Hide resolved
src/lib/components/bottom-nav.svelte Outdated Show resolved Hide resolved
@GiantRobots GiantRobots merged commit bc32f5a into main Dec 11, 2024
14 checks passed
@GiantRobots GiantRobots deleted the ExposeMoreControlsForBottomNav branch December 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants