Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename resource aws_appsync_api_cache #62

Closed
wants to merge 1 commit into from
Closed

fix: Rename resource aws_appsync_api_cache #62

wants to merge 1 commit into from

Conversation

srouaix
Copy link

@srouaix srouaix commented Jun 19, 2024

The name "example" is not appropriate in the module for the resource aws_appsync_api_cache

Description

Rename aws_appsync_api_cache ressource as "example" seems an error

Motivation and Context

It is sad in the states and logs of terrform plan - apply

Breaking Changes

Necessary to add moved instruction to avoid destroy create resource. Probably a breaking change

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

The name "example" is not appropriate in the module for the resource aws_appsync_api_cache
@srouaix srouaix changed the title fix: rename resource aws_appsync_api_cache Fix: rename resource aws_appsync_api_cache Jun 19, 2024
@srouaix srouaix changed the title Fix: rename resource aws_appsync_api_cache fix: Rename resource aws_appsync_api_cache Jun 19, 2024
@taufort
Copy link

taufort commented Dec 23, 2024

Hi @antonbabenko 👋

Why did you close this PR?

We could have created a new major release and added a migration.md file to explain how to migrate from previous version to the new one. The naming of the resource in the module is not appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants