Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMI has first-order dependencies that are not declared in our pyproject.toml #2038

Closed
john-science opened this issue Dec 19, 2024 · 1 comment · Fixed by #2039
Closed

ARMI has first-order dependencies that are not declared in our pyproject.toml #2038

john-science opened this issue Dec 19, 2024 · 1 comment · Fixed by #2039
Assignees
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation

Comments

@john-science
Copy link
Member

john-science commented Dec 19, 2024

Okay, ARMI is not declaring these runtime first-order dependencies, because (I am guessing) they are also second-order dependencies. But I consider this a failure of documentation:

  • python-dateutil - used in armi/utils/parsing.py
  • mpl_toolkits - NVM, this is part of mat-props

Similarly, ARMI is not declaring this first-order test dependence:

  • nbformat - used in test_historyTracker.py and test_notebooks.py

Lastly, ARMI has two dependencies that I find suspect because we are importing an ENTIRE dependency for one function:

  • pyDOE - only used in one place
  • python-dateutil - only used once, to read datetime strings slightly more easily.
@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority labels Dec 19, 2024
@john-science john-science self-assigned this Dec 19, 2024
@john-science
Copy link
Member Author

As a historical note, I first did this research because @drewj-tp opened a ticket, and I thought to do a little digging in a more general context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant