Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifying all first-order dependencies #2039

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

john-science
Copy link
Member

What is the change?

I added two first-order dependencies to the pyproject.toml file.

Why is the change being made?

These are ALSO second-order dependencies. So ARMI builds fine with the pyproject.toml file as-is. But I consider this a failure of documentation. And Drew notes that we have less control as things stand.

Generally, I just want to declare all our first-order dependencies as such.

close #2038

(NOTE: I thought we had another first-order dep, mpl_toolkits, but it turns out that is just part of the matprops namespace.)


Checklist

  • The release notes have been updated if necessary. (I don't believe this warrants a release note.)
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority labels Dec 19, 2024
pyproject.toml Show resolved Hide resolved
@john-science john-science merged commit f86ef61 into main Dec 20, 2024
22 checks passed
@john-science john-science deleted the first_order_deps branch December 20, 2024 17:29
@john-science john-science changed the title First order deps Identifying all first-order dependencies Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARMI has first-order dependencies that are not declared in our pyproject.toml
2 participants