Identifying all first-order dependencies #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
I added two first-order dependencies to the
pyproject.toml
file.Why is the change being made?
These are ALSO second-order dependencies. So ARMI builds fine with the
pyproject.toml
file as-is. But I consider this a failure of documentation. And Drew notes that we have less control as things stand.Generally, I just want to declare all our first-order dependencies as such.
close #2038
(NOTE: I thought we had another first-order dep, mpl_toolkits, but it turns out that is just part of the matprops namespace.)
Checklist
doc
folder.pyproject.toml
.