Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning out unnecessary uses of r.o #1999

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Cleaning out unnecessary uses of r.o #1999

merged 3 commits into from
Nov 22, 2024

Conversation

john-science
Copy link
Member

What is the change?

Here I clean out all the unnecessary usages of r.o.

(I also remove the CustomModifier class, which is entirely unused in ARMI or anywhere downstream. I checked. And it was a major user of r.o.)

Why is the change being made?

This PR is progress towards, but not a complete picture of Jake's ticket to completely remove the Operator from the Reactor; #830.

What this PR leaves is the central usage and problem to solve the r.o problem, the fact that our Interface class just throws around r.o and o.r willy nilly:

self.o = r.o if r else None


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Nov 1, 2024
@john-science john-science requested review from opotowsky and removed request for jakehader November 21, 2024 21:18
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

armi/reactor/assemblies.py Outdated Show resolved Hide resolved
armi/reactor/assemblies.py Outdated Show resolved Hide resolved
Co-authored-by: Tony Alberti <[email protected]>
@john-science john-science merged commit f5dcc1d into main Nov 22, 2024
22 checks passed
@john-science john-science deleted the cleanup_r_o branch November 22, 2024 17:16
drewj-tp added a commit that referenced this pull request Nov 22, 2024
…pin-dep

* origin/main:
  Improving calculation for total job memory (#2018)
  Cleaning out unnecessary uses of r.o (#1999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants