Cleaning out unnecessary uses of r.o #1999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Here I clean out all the unnecessary usages of
r.o
.(I also remove the
CustomModifier
class, which is entirely unused in ARMI or anywhere downstream. I checked. And it was a major user ofr.o
.)Why is the change being made?
This PR is progress towards, but not a complete picture of Jake's ticket to completely remove the
Operator
from theReactor
; #830.What this PR leaves is the central usage and problem to solve the
r.o
problem, the fact that ourInterface
class just throws aroundr.o
ando.r
willy nilly:armi/armi/interfaces.py
Line 338 in e777af7
Checklist
doc
folder.pyproject.toml
.