Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finishing up the numProcessors -> nTasks conversion #2002

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Finishing up the numProcessors -> nTasks conversion #2002

merged 1 commit into from
Nov 4, 2024

Conversation

zachmprince
Copy link
Contributor

@zachmprince zachmprince commented Nov 1, 2024 •
edited by john-science
Loading

What is the change?

Renaming numProcessors to nTasks in test settings files.

Why is the change being made?

#1958 renamed this setting, but there are some settings files in the armi/tests directory that continue to use it.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@zachmprince zachmprince added cleanup Code/comment cleanup: Low Priority low priority Style points and non-features labels Nov 1, 2024
@john-science john-science merged commit cd616ed into terrapower:main Nov 4, 2024
12 checks passed
drewj-tp added a commit that referenced this pull request Nov 7, 2024
@drewj-tp
Merge remote-tracking branch 'zprince/component_flux_up' into drewj/b…
4ed2f3f 
…u-rotate-with-pin-dep

* zprince/component_flux_up:
  fix linting
  release notes
  Enabling axial expansion with detailed depletion (#1954)
  Improving error testing (#2004)
  Addressing reviewer comments for component pin mg fluxes
  Removing mystery coverage line from tests (#2003)
  beef up assertions
  resolve fixme
  org imports
  No need to recast strings to strings
  Finishing up the numProcessors -> nTasks conversion (#2002)
  Using one-block reactor for component flux test
  Supporting Python 3.13 (#1996)
  Removing SmartList & adding coverage (#1992)
  Update `copyOrWarn` and `getFileSHA1Hash` to account for directories (#1984)
  Removing broken plot (#1994)
  Adding unit tests for `CylindricalComponentsDuctHetAverageBlockCollection` (#1991)
  Allowing creation of partially heterogeneous assemblies for 1D XS model (#1949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

@opotowsky opotowsky Awaiting requested review from opotowsky

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority low priority Style points and non-features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmprince @john-science