-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose some skip inspection options for armi.init
and db.loadOperator
#2005
Conversation
armi.init
and db.loadOperator
Looks great. It really could use some unit testing for the DB stuff. (Testing |
Is this only needed for interactive mode? What's the scenario where someone needs to babysit settings queries? Not a huge fan of adding more kwargs to init so I'm curious if we have the right check inputs design. |
Yes this is needed for interactive mode, when someone runs a python script on the command line. I guess we could skip the checkInputs on armi init....but I didn't feel empowered to make such a big change. |
Co-authored-by: John Stilley <[email protected]>
…ore-inspections
…ower/armi into skip-more-inspections
…pin-dep * origin/main: Moving from shutil.copy to safeCopy (#2024) Move files from temporary directory changer (#2022) Handling checking for OSs better (#2023) Expose some skip inspection options for `armi.init` and `db.loadOperator` (#2005) Adding setting to control MCNP / ENDF library (#1989) Improving logging on ISOTXS compare (#2013)
What is the change?
This exposes a
skipInspection
option toarmi.init
and ahandleInvalids
optiondb.loadOperator
. The original behavior is retained by default.Why is the change being made?
Folks write scripts that use the API, and when they run these scripts, they are often stuck in settings inspection mode (typing
y
+<enter>
over and over if they are loading older settings files). This helps them skip said inspections so they can run scripts without babysitting them.Checklist
doc
folder.pyproject.toml
.