Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting imports with ruff #2025

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Sorting imports with ruff #2025

merged 4 commits into from
Dec 24, 2024

Conversation

john-science
Copy link
Member

What is the change?

Sorting the imports with ruff.

Why is the change being made?

A few times in the last month, I have had to bother people in their PRs about alphabetizing imports. Well, that's boring and a waste of time.

I think ruff does a good job with making all our imports consistent, but not breaking the paradigms we have. So, this seems better.

close #2021


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Dec 2, 2024
@opotowsky
Copy link
Member

What is the addition of the I001 ignores doing?

@john-science
Copy link
Member Author

What is the addition of the I001 ignores doing?

As it turns out, if you alphabetize the imports in those two files, then we get circular import errors.

Fun!

That's worth me looking at and fixing. But this PR is already big enough, I didn't want to mingle the two ideas and make it harder on you.

@john-science
Copy link
Member Author

Again, I apologize for myself.

What a thing to review.

Please consider there is no timeline for this.

And scream if I need to break this into smaller PRs or something. I can do that!

@opotowsky
Copy link
Member

Haha no worries! maybe next week! or while I'm flying

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did it!

@opotowsky opotowsky merged commit bc1ec01 into main Dec 24, 2024
22 checks passed
@opotowsky opotowsky deleted the ruff_imports branch December 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort imports using ruff
2 participants