Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing _getParamMax for Volume-Integrated Assembly Params #2033

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Fixing _getParamMax for Volume-Integrated Assembly Params #2033

merged 3 commits into from
Dec 11, 2024

Conversation

bsculac
Copy link
Contributor

@bsculac bsculac commented Dec 11, 2024 •
edited
Loading

What is the change?

Update FuelHandler._getParamMax to account for assembly parameters instead of only looking at block parameters.

Why is the change being made?

#2017 introduced a bug where looking for the maximum parameter on an assembly would fail. This fixes that function to account for assembly parameters, while also allowing for future use of volume integrated assembly parameters with the function.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science self-requested a review December 11, 2024 21:38
@john-science john-science changed the title Fix _getParamMax symmetry to account for volume integrated assembly parameters Fixing _getParamMax for Volume-Integrated Assembly Params Dec 11, 2024
@john-science john-science added cleanup Code/comment cleanup: Low Priority bug Something is wrong: Highest Priority and removed cleanup Code/comment cleanup: Low Priority labels Dec 11, 2024
@bsculac bsculac marked this pull request as ready for review December 11, 2024 22:21
@john-science john-science merged commit c078cde into main Dec 11, 2024
22 checks passed
@john-science john-science deleted the fix_getParamMax branch December 11, 2024 23:05
drewj-tp added a commit that referenced this pull request Dec 12, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/composite-iter/…
9249016 
…1915

* origin/main:
  Fixing _getParamMax for Volume-Integrated Assembly Params (#2033)
  Accounting for symmetry in volume-integrated parameters (#2017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsculac @john-science