add validation for sequence diagram edges to descendant

terrastruct · Oct 2, 2023 · 84affc9 · 84affc9
1 parent a8af739
commit 84affc9
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/d2compiler/compile.go b/d2compiler/compile.go
@@ -1102,6 +1102,14 @@ func (c *compiler) validateEdges(g *d2graph.Graph) {
 			c.errorf(edge.GetAstEdge(), "edge from grid cell %#v cannot enter itself", edge.Dst.AbsID())
 			continue
 		}
+		if edge.Src.IsSequenceDiagram() && edge.Dst.IsDescendantOf(edge.Src) {
+			c.errorf(edge.GetAstEdge(), "edge from sequence diagram %#v cannot enter itself", edge.Src.AbsID())
+			continue
+		}
+		if edge.Dst.IsSequenceDiagram() && edge.Src.IsDescendantOf(edge.Dst) {
+			c.errorf(edge.GetAstEdge(), "edge from sequence diagram %#v cannot enter itself", edge.Dst.AbsID())
+			continue
+		}
 	}
 }