Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dagre id registration #1619

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes id registration bug in #1610, when a child appears before its parent in graph.Objects.

Details

  • Register all objects first, then add to dagre
  • previously a child would try to find a parent that wasn't registered yet
  • adds disclaimer test

new test

Screenshot 2023-09-25 at 4 34 10 PM

@gavin-ts gavin-ts requested a review from alixander September 25, 2023 23:37
@gavin-ts gavin-ts enabled auto-merge September 25, 2023 23:39
@gavin-ts gavin-ts merged commit ae128ac into terrastruct:master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants