Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MkDocs Plugin to community plugins #1621

Merged
merged 1 commit into from
Oct 6, 2023
Merged

add MkDocs Plugin to community plugins #1621

merged 1 commit into from
Oct 6, 2023

Conversation

landmaj
Copy link
Contributor

@landmaj landmaj commented Sep 26, 2023

This PR adds MkDocs Plugin to the list of community plugins.

At work we are in the process of switching from PlantUML to D2 and I discovered there was no plugin for MkDocs, which we use to generate documentation for our clients. So I wrote one. You can see a result of using the plugin here.

@gavin-ts
Copy link
Contributor

gavin-ts commented Oct 5, 2023

oh sorry could you sign the commit? #557 (comment)

@landmaj
Copy link
Contributor Author

landmaj commented Oct 5, 2023

Sorry, I didn't notice the requirement before. At least I learned something new today, I've never done it before. 🙂 Should be signed now.

@gavin-ts
Copy link
Contributor

gavin-ts commented Oct 5, 2023

thanks! We've run into this a few times where we don't notice the commit signature missing until after a review approval, so I just made this into its own clear check here: terrastruct/ci#28 and it should make its way into the d2 repo soon.

@gavin-ts gavin-ts merged commit 65fd4b7 into terrastruct:master Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants