cli: add play cmd #2242
Open
cli: add play cmd #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Dec 12, 2024
| @@ -38,6 +39,7 @@ Subcommands: | |||
| %[1]s layout [name] - Display long help for a particular layout engine, including its configuration options | |||
| %[1]s themes - Lists available themes | |||
| %[1]s fmt file.d2 ... - Format passed files | |||
| %[1]s play file.d2 - Opens the file in playground | |||
There was a problem hiding this comment.
playground might be unknown to folks. I'd add a description like Opens the file in the d2 playground, an online web viewer
| @@ -154,6 +154,8 @@ func Run(ctx context.Context, ms *xmain.State) (err error) { | |||
| return nil | |||
| case "fmt": | |||
| return fmtCmd(ctx, ms) | |||
| case "play": | |||
| return playSubcommand(ctx, ms) | |||
There was a problem hiding this comment.
playCmd to conform with above naming standards
Comment on lines
+14
to
+16
| if len(ms.Opts.Flags.Args()) != 2 { | ||
| return xmain.UsageErrorf("play must be passed one file to open") | ||
| } |
There was a problem hiding this comment.
it should also allow stdin
| return err | ||
| } | ||
|
|
||
| url := fmt.Sprintf("https://play.d2lang.com/?l=&script=%s&sketch=%d&theme=%d&", encoded, sketchNumber, theme) |
There was a problem hiding this comment.
This was in the URL provided in the issue. I'll remove.
I'm assuming you'd consider this a feature? Or should I put it under improvements? |
|
yeah that's a feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1213 - Added play command to cli that opens the playground with the given diagram, theme and sketch flag.