Improve freshness verbosity #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They end up clogging the logs as often due to burrow configs consumers can be returned but not have any lag information available. This can cause the logs to be filled with useless stack traces of REST 404 errors from the burrow lag queries. Instead, we just log the one-line message containing the Response information - everything that is actually useful in debugging a 404.
This gives consumers a flag to toggle - turning on DEBUG level logging - that though it is verbose, will allow them to see what is actually happening under the hood in the freshness tracker. This can be very useful for debugging 'weird' results from freshness computations. This also meant turning down the Burrow GET request logging from DEBUG to TRACE as we really dont need to see the requests in the logs at DEBUG when we are getting that same response information in ConsumerFreshness (albeit slightly massaged).
danielfritsch
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For burrow 404 errors, we avoid dumping the entire stack trace, but instead just log the exception message and move along. This dramatically cuts down log verbosity during normal operations, allowing the operator to see 'real' errors.
For when things get wonky, we need a way to see what the freshness tracker is using to calculate freshness - the current consumer state and the 'next' record against which freshness is calculated. Putting this at DEBUG lets us see what is happening, albeit with high degree of verbosity (most folks should not run at DEBUG normally though, this is just for debugging persistent tracker issues).
Addresses #59