feat: add community module for permify service #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Could you update the module's README? It still uses RunContainer in the code snippets https://github.com/theoriginalstove/testcontainers-permify/blob/main/README.md?plain=1#L39
Thanks!
|
@mdelapenya of course! Didn't realize I forgot to update the examples in the README. Thanks for pointing that out 😅 Should be updated now. |
kiview
approved these changes
Aug 12, 2024
|
Thanks for adding this and working on the module @theoriginalstove 🙌 |
|
No problem! There was plenty of examples and docs to make it easy and quick to create it. I think I spent 3x the hours trying figure out why the tests failed in the Github action vs passing locally 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to create a community module for Permify since I also wanted to use testcontainers within my own go code and saw this issue on the Permify repo: Permify/permify#1304