Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CONTRIBUTING.md #14

wants to merge 1 commit into from

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Mar 17, 2020

No description provided.

tgalopin
tgalopin reviewed Mar 17, 2020
View reviewed changes
Copy link
Owner

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much Lucas! Here are a few comments

composer.json Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Lucas-C Lucas-C force-pushed the contributing branch 3 times, most recently from 18bb523 to 4ca9b13 Compare March 18, 2020 22:04
@Lucas-C
Copy link
Contributor Author

Lucas-C commented Mar 18, 2020

I think I addressed all your comments.
Do you see anything that remain to be improved before merging this ? :)

@froulet froulet mentioned this pull request Mar 19, 2020
Merged
@Lucas-C
Copy link
Contributor Author

Lucas-C commented Apr 3, 2020

Can this be merged ?

Preview : https://github.com/Lucas-C/enpremiereligne.fr/blob/contributing/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgalopin tgalopin tgalopin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucas-C @tgalopin